-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Quotecall #191
Add Quotecall #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contract logic looks sound to me, though this PR is missing unit tests.
Quotecall is like Paycall, except it always sends a specific quote of USDC to `tx.origin` allowing for minor changes in gas price (i.e. via a `deltaBps` parameter). As the USDC is sent _before_ the sub-transaction is run, this allow things like "send max USDC" to properly work as expected. As the quote is fixed, this means that recurring or delayed transactions are very _unlikely_ to work with this script.
6594583
to
778b6f5
Compare
I took over the branch and made the following improvements/changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Geoff reviewed my changes and gave the LGTM. I'll go ahead and approve and merge since this is his PR and he can't give the approval.
Quotecall is like Paycall, except it always sends a specific quote of USDC to
tx.origin
allowing for minor changes in gas price (i.e. via amaxDeltaPercentage
parameter). As the USDC is sent before the sub-transaction is run, this allow things like "send max USDC" to properly work as expected. As the quote is fixed, this means that recurring or delayed transactions are very unlikely to work with this script.