Fix natspecs and tiny refactor to follow checks-effects-interactions #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayesgm
approved these changes
Mar 15, 2024
| address cachedScriptAddress = nonceScriptAddress[msg.sender][nonce]; | ||
| // if the nonce has been used before, check if the script address matches, and revert if not | ||
| if ((cachedScriptAddress != address(0)) && (cachedScriptAddress != scriptAddress)) { | ||
| revert NonceScriptMismatch(); | ||
| } | ||
|
|
||
| // spend the nonce; only if the callee chooses to clear it will it get un-set and become replayable |
There was a problem hiding this comment.
This should have no observable difference right, since we're not making external calls in the intermediate?
There was a problem hiding this comment.
Yeah, this will have no functional difference. The change just makes our code conform better to checks-effects-interactions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some natspecs, removes some outdated documentation, and moves the
setNonceInternalcall insetActiveNonceAndCallbackto until after all the checks are done.