Non-functional refactoring and improvements #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut into separate files
…name HasSignerExecutor to IHasSignerExecutor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing to address some of the minor ABDK audit issues I think are worth addressing. Though tedious, I think these changes help to clean up our code a bit to improve readability and organization.
Changes:
IExecutortoIQuarkWalletreceive()fallbacksUniswapFlashLoan.solI also changed a few of our tests to use the
QuarkMinimalProxyinstead of theQuarkWalletStandalone. This may require us to run the gas snapshot again because it will surely bump up some of the gas costs in our tests.