Code Jar Deployments #173
Merged
Code Jar Deployments #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch switches our core Factory to be `CodeJarFactory` that deploys `CodeJar` deterministically via `scripts/deploy-code-jar.sh`. After that, you're expected to pass in `CODE_JAR` to the deployment script which now depends on using that same Code Jar for deployments. The key benefit here is that we can re-use that same CodeJar access multiple network deployments. In fact, if we get a consistent CodeJar address on all chains (e.g. via running the deployment script on all standard EVM chains), then we can use whatever key to deploy any new Quark Factory contracts and they will always end up at the same address on all chains. This should make multi-chain deployments a breeze! Plus, everything _should_ be verifiable, etc, on Etherscan now, too.
hayesgm
force-pushed
the
hayesgm/codejar-deploys
branch
from
ef0a8e7 to
9f84a97
Compare
fluffywaffles
approved these changes
Mar 5, 2024
kevincheng96
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Woot! LGTM
If you have the chance, would be great to update the Deploy section of the README as well with the new flow.
Co-authored-by: Kevin Cheng <[email protected]>
kevincheng96
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch switches our core Factory to be
CodeJarFactorythat deploysCodeJardeterministically viascripts/deploy-code-jar.sh. After that, you're expected to pass inCODE_JARto the deployment script which now depends on using that same Code Jar for deployments.The key benefit here is that we can re-use that same CodeJar access multiple network deployments. In fact, if we get a consistent CodeJar address on all chains (e.g. via running the deployment script on all standard EVM chains), then we can use whatever key to deploy any new Quark Factory contracts and they will always end up at the same address on all chains. This should make multi-chain deployments a breeze!
Plus, everything should be verifiable, etc, on Etherscan now, too.