Skip to content

Commit

Permalink
CS 5.3 - Small interface updates (#198)
Browse files Browse the repository at this point in the history
Two changes:

- Remove `isValidSignature` from `IQuarkWallet` since it is a function
that belongs to `IERC1271`
- Have `QuarkMinimalProxy` extend `IHasSignerExecutor`
  • Loading branch information
kevincheng96 authored Jun 4, 2024
1 parent e1da89d commit 99414d6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 0 additions & 1 deletion src/quark-core/src/interfaces/IQuarkWallet.sol
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ interface IQuarkWallet {
function getDigestForQuarkOperation(QuarkOperation calldata op) external view returns (bytes32);
function getDigestForMultiQuarkOperation(bytes32[] memory opDigests) external pure returns (bytes32);
function getDigestForQuarkMessage(bytes memory message) external view returns (bytes32);
function isValidSignature(bytes32 hash, bytes memory signature) external view returns (bytes4);
function executeScriptWithNonceLock(address scriptAddress, bytes memory scriptCalldata)
external
returns (bytes memory);
Expand Down
4 changes: 3 additions & 1 deletion src/quark-proxy/src/QuarkMinimalProxy.sol
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
// SPDX-License-Identifier: BSD-3-Clause
pragma solidity 0.8.23;

contract QuarkMinimalProxy {
import {IHasSignerExecutor} from "quark-core/src/interfaces/IHasSignerExecutor.sol";

contract QuarkMinimalProxy is IHasSignerExecutor {
/// @notice Address of the EOA signer or the EIP-1271 contract that verifies signed operations for this wallet
address public immutable signer;

Expand Down

0 comments on commit 99414d6

Please sign in to comment.