Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CCTP Bridger #1

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Add CCTP Bridger #1

merged 6 commits into from
Jun 5, 2024

Conversation

cwang25
Copy link
Contributor

@cwang25 cwang25 commented Jun 5, 2024

No description provided.

@cwang25 cwang25 requested a review from kevincheng96 June 5, 2024 20:06
@cwang25
Copy link
Contributor Author

cwang25 commented Jun 5, 2024

[FAIL. Reason: setup failed: Could not instantiate forked environment with fork url: https://node-provider.compound.finance/ethereum-mainnet/] setUp() (gas: 0)

Looks like this repo hasn't set up the proper forking access to Infura?

kevincheng96
kevincheng96 reviewed Jun 5, 2024
View reviewed changes
Copy link
Contributor

@kevincheng96 kevincheng96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left some comments

src/DeFiScripts.sol Outdated Show resolved Hide resolved
test/CCTPBridge.t.sol Outdated Show resolved Hide resolved
test/CCTPBridge.t.sol Outdated Show resolved Hide resolved
@kevincheng96
Copy link
Contributor

Looks like this repo hasn't set up the proper forking access to Infura?

I just added the NODE_PROVIDER_BYPASS_KEY secret to this repo. Let's give it another run and see if it works.

@cwang25 cwang25 requested a review from kevincheng96 June 5, 2024 21:36
kevincheng96
kevincheng96 reviewed Jun 5, 2024
View reviewed changes
src/DeFiScripts.sol Outdated Show resolved Hide resolved
@cwang25 cwang25 merged commit 50ef01d into main Jun 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincheng96 kevincheng96 kevincheng96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwang25 @kevincheng96