Make psql shell #1627
Open
Make psql shell #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ballPointPenguin
approved these changes
Feb 21, 2023
metasoarous
commented
Mar 4, 2023
Makefile
Outdated
| @@ -86,14 +86,18 @@ e2e-run-all: ## Run E2E tests: all | |||
| $(E2E_RUN) npm run e2e:all | |||
|
|
|||
|
|
|||
| psql-shell: ## Assuming a system is already running with `make start`, start up an interactive psql shell | |||
| docker-compose exec postgres psql --username postgres --dbname polis-dev | |||
There was a problem hiding this comment.
@ballPointPenguin Should this actually be --db-name polis-$TAG? Not sure how dev gets set, but assuming that's not right for production connections...
There was a problem hiding this comment.
Maybe it should pull DB_NAME from env
|
@ballPointPenguin Seeing this is approved, is this something we want to merge? |
ballPointPenguin
requested changes
Nov 19, 2024
ballPointPenguin
force-pushed
the
make-psql-shell
branch
from
00739b3
to
d010378
Compare
ballPointPenguin
approved these changes
Nov 23, 2024
|
I updated this to use the provided .env to determine how to connect to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a just a little
Makefileaddition for firing up a psql shell by runningmake psql-shell.