This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
FSPT-119 Remove SCSS preprocess step #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
It doesn't look like the `assets.py` build step is used anymore (in favour of the static assets build step?) so remove it. Move the scss files to css in preparation from removing the preprocessor.
We aren't importing and using the colour variables that would track design system changes anyway. Remove the variables for now - if we start building on the design system scss and bundling appropriately we can add that back in.
Now that the files are just css remove the pyscss filter step. This lets us remove the dependency. While I'm here it doesn't look like pyopenssl is removed so remove that.
sfount
force-pushed
the
FSPT-119-remove-pyscss
branch
from
e03f7b7 to
b53834a
Compare
MarcUsher
approved these changes
Dec 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We aren't importing and using the colour variables that would track
design system changes anyway. Remove the variables for now - if we start
building on the design system scss and bundling appropriately we can add
that back in.
Now that the files are just css remove the pyscss filter step. This lets
us remove the dependency.
While I'm here it doesn't look like pyopenssl is used so remove that.
It doesn't look like the
assets.pybuild step is used anymore (infavour of the static assets build step?) so remove it.