Change caching pathmapper to respect the pathmapper factory #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2092 +/- ##
==========================================
- Coverage 84.74% 84.73% -0.02%
==========================================
Files 46 46
Lines 8337 8337
Branches 1960 1960
==========================================
- Hits 7065 7064 -1
+ Misses 805 804 -1
- Partials 467 469 +2 ☔ View full report in Codecov by Sentry. |
mr-c
approved these changes
Jan 10, 2025
|
Thank you @stxue1 ! I'll make a new release of cwltool including this fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the PathMapper construction in caching to support the pathmapper factory by calling
self.make_path_mapperinstead of directly constructingPathMapper. This should allow Toil to hook its own pathmapper in when caching is enabled and allow DataBiosphere/toil#5187 to work.