Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sandwich-webdriver, sandwich-contexts: enable at 0.3.0.0 #7564

Merged

Conversation

thomasjm
Copy link
Contributor

@thomasjm thomasjm commented Nov 4, 2024

Fixes codedownio/sandwich#100. CC @alaendle

Hopefully it's okay to add both sandwich-webdriver and its dependency sandwich-contexts together like this.

It's possible we'll need to skip the tests of sandwich-contexts, since they require Nix.

Checklist:

  • Meaningful commit message, eg add my-cool-package (please not mention build-constraints.yml)

  • At least 30 minutes have passed since uploading to Hackage

  • On your own machine, you have successfully run the following command (find verify-package in the root of this repo):

    ./verify-package $package # or $package-$version
    

(Verified sandwich-contexts.)

@mihaimaruseac mihaimaruseac merged commit 5a8eb2d into commercialhaskell:master Nov 4, 2024
1 check passed
@mihaimaruseac
Copy link
Contributor

Tests for sandwich-contexts are failing as they expect nix:

           Run root: /home/curators/work/unpack-dir/unpacked/sandwich-contexts-0.3.0.0-4ac53faea4343eb7239489189a55f1f1f1bdedde638b7b86a8bb2c99db963ed8/test_runs/2024-11-05T01_47_20.845729156Z                    
                                                                                                                                                                                                                    
             Spec                          
                 Nix                                                                                      
                     can build a Nix environment with some binaries
                         Context exception:                                                               
                         Reason:                                                                          
                             Couldn't find "nix" binary when introducing Nix context. A Nix binary and store must already be available in the environment.
                                                                                                          
                     ^ Introduce Nix context                                                              
                     Reason: 
                         Couldn't find "nix" binary when introducing Nix context. A Nix binary and store must already be available in the environment.

Will completely skip tests for this

mihaimaruseac added a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No longer compiles on stackage - guess some dependency update broke it.
2 participants