Fix reactions modal #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i.e. not the complete rendered template
but call it users_reacted_to_object.html, as it's referenced in django-comments-ink.views.reacting.ReactedToObjectUserListView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per comments-ink/django-comments-ink#59 , there seems to be a miss-match between the name of the template used in
views.reacting.ReactedToObjectUserListViewand the code that would work withmodal.js.Here I've only created a link to
list_reacted_to_object.html(which seems to be what modal.js expects), with the name used in the view, but it's not the ideal solution.I'm not sure how to proceed:
I think
list_reactedis not used as template name in django-comments-ink, so I'd be inclined toward solution 1 🙂This PR depends on this PR on the main project side.