Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msgq: Check MAP_FAILED Instead of NULL for mmap #614

Merged
merged 2 commits into from
Aug 4, 2024
Merged

msgq: Check MAP_FAILED Instead of NULL for mmap #614

merged 2 commits into from
Aug 4, 2024

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented May 27, 2024

The mmap function does not return NULL on failure; it returns MAP_FAILED.

@adeebshihadeh adeebshihadeh merged commit 622de23 into commaai:master Aug 4, 2024
8 checks passed
@deanlee deanlee deleted the fix_mmap_error_handle branch August 5, 2024 03:37
adurham added a commit to adurham/msgq that referenced this pull request Sep 20, 2024
@adurham
Squashed commit of the following:
3b722b6 
commit cdcf84f
Author: Shane Smiskol <[email protected]>
Date:   Tue Aug 27 20:10:33 2024 -0700

    Better compiler compatibility

commit cff3a55
Author: Dean Lee <[email protected]>
Date:   Sat Aug 24 01:42:31 2024 +0800

    remove libcereal_shared from .gitignore (commaai#630)

    remove shared creal

commit 23cb05a
Author: Dean Lee <[email protected]>
Date:   Mon Aug 5 06:02:07 2024 +0800

    visionbuf: fix incorrect length passed to munmap (commaai#618)

    Fix incorrect length passed to munmap

commit 622de23
Author: Dean Lee <[email protected]>
Date:   Mon Aug 5 05:53:06 2024 +0800

    msgq: check MAP_FAILED instead of NULL for mmap (commaai#614)

commit 45110ff
Author: Shane Smiskol <[email protected]>
Date:   Wed Jul 31 21:49:42 2024 -0700

    fix mypy configuration header (commaai#629)

    did this work?

commit 37e734b
Author: Shane Smiskol <[email protected]>
Date:   Wed Jul 31 19:09:21 2024 -0700

    fix PYTHONPATH (commaai#628)

    pythonpath was wrong, the location is what saved us
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deanlee @adeebshihadeh