flash extra.json manifest
#165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incognitojam
force-pushed
the
agnos-extra
branch
from
0d939c2
to
a34157a
Compare
There was a problem hiding this comment.
Where does the extra manifest live? This should have no impact on the current AGNOS release flow, and it should all just work. Took a stab at simplifying this in #170; I think that'll work with openpilot's updater (and it's a big red diff!)
internal/extra_push.sh
Outdated
| local SPARSE=$(cat $EXTRA_JSON | jq -r ".[] | select(.name == \"$NAME\") | .sparse") | ||
|
|
||
| if [ "$SPARSE" == "true" ]; then | ||
| upload_file "$NAME-$HASH_RAW-optimized.img.gz" |
There was a problem hiding this comment.
optimized is kind of a misnomer here - it's just "special". maybe call it "skipped-chunks"
| EXTRA_JSON="$OTA_OUTPUT_DIR/extra.json" | ||
| EXTRA_STAGING_JSON="$OTA_OUTPUT_DIR/extra-staging.json" | ||
|
|
||
| process_file() { |
There was a problem hiding this comment.
seems like this file has a ton of duplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.