Enable interface selection for algorithm job #3753
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amickan
commented
Dec 16, 2024
app/grandchallenge/algorithms/migrations/0065_create_interfaces_for_jobs.py
Outdated
Show resolved
Hide resolved
amickan
commented
Dec 16, 2024
amickan
commented
Dec 16, 2024
amickan
commented
Dec 16, 2024
|
As I'm working on the failing tests, I'm realizing that a lot of the tests on job creation through the API for example, will fail with these changes here unless I also tackle the API views (which I was gonna do in a separate PR). I could mark those as expected to fail, but then I need to be very careful to remove those marks in the next PR again. I could also tackle the API views here as well, but then it becomes a much larger PR. |
amickan
commented
Dec 16, 2024
jmsmkn
pushed a commit
that referenced
this pull request
Dec 18, 2024
This updates the `VerificationRequiredMixin` to directly subclass `AccessMixin`. This makes it possible to include this mixin in views where another `AccessMixin` is used as well. Discussed in #3753 (comment)
amickan
commented
Dec 19, 2024
app/grandchallenge/algorithms/migrations/0065_create_interfaces_for_jobs.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm unsure about some parts of this implementation, so putting this here in draft mode for early feedback. Tests still need fixing as well.
Part of https://github.com/DIAGNijmegen/rse-roadmap/issues/153