Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust quote styling #3752

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Adjust quote styling #3752

merged 3 commits into from
Dec 17, 2024

Conversation

koopmant
Copy link
Contributor

@koopmant koopmant commented Dec 13, 2024

Adjust blockquote style to make quotes more obvious.

closes #3623

@koopmant koopmant requested a review from jmsmkn as a code owner December 13, 2024 18:08
@koopmant koopmant self-assigned this Dec 13, 2024
@koopmant
Copy link
Contributor Author

I ended up simply adding some css.

It took me a long time to find out that there was no css being overridden anywhere. The blockquote style with a border on the left is part of an older bootstrap version (at least still there in 3.3.2).

Markdownx does not inject any css, although there is some css included for the admin site.

@koopmant
Copy link
Contributor Author

Preview

image

@koopmant
Copy link
Contributor Author

Preview:
image

I've opted for the primary color now, because the bootstrap gray colors are overridden in our flatly theme and that does not leave me with the dark gray that I'd like to use. (Not sure why Flatly chose to do it this way; I think it's a bit odd because this leaves a gap in between gray-700 and gray-800, see below.)
I thought about resetting the gray colors back to the bootstrap original values, but then I'd have to apply fixes for those changes as well (such as setting the secondary color from gray-600 to gray-500), so I decided to not do that.

Flatly (left), bootstrap (right). Gray 500, 600, and 700 are overridden.
image image

@jmsmkn
Copy link
Member

jmsmkn commented Dec 16, 2024

I get this when trying to merge, do not know what is going on:

Screenshot 2024-12-16 at 16 00 44

@koopmant
Copy link
Contributor Author

I see the same thing when I try it. I have not experienced this before.

@jmsmkn jmsmkn merged commit 02391c6 into main Dec 17, 2024
8 checks passed
@jmsmkn jmsmkn deleted the style-quotes branch December 17, 2024 07:50
@jmsmkn
Copy link
Member

jmsmkn commented Dec 17, 2024

It fixed itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quoted text not clear
2 participants