Removes oninput for challenge request form #3751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old functionality was to drop invalid values, this does not seem user friendly. Now, we use the default behavioud of the browser forcing the user to fill in a valid value when they try to submit the form instead. Closes #3748
amickan
previously approved these changes
Dec 13, 2024
|
My guess is for making it easier for the budget response from HTMX, but I don't think that is done anymore. |
Ah that's very possible, but that was indeed removed. |
amickan
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old functionality was to drop invalid values, this does not seem user friendly. Now, we use the default behaviour of the browser forcing the user to fill in a valid value when they try to submit the form instead.
This also removes the budget default of zero which prevents the requester overlooking the field.
Closes #3748