Upgrade Datatables #3738
Merged
Upgrade Datatables #3738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last update to Datatables was from a release that was from 24th September, 2021. Since I had my hands in the Datatables last week I thought now would be a good time to bump the version.
The latest (2.1.8) has jquery as a hard dependency, so no need to explicitly select that any more.
It was nearly a perfect drop-in replacement, with the exception of:
ajax.urldoes not default to the current HREF when set to"". Rather"."does.order[...]XML arguments in the xhr request. Instead, I've made it so that the data ordering falls back to the default found on the implementing class. Imho that is superior to random ordering.