Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix job page #3516

Closed
wants to merge 5 commits into from
Closed

[WIP] Fix job page #3516

wants to merge 5 commits into from

Conversation

chrisvanrun
Copy link
Contributor

@chrisvanrun chrisvanrun commented Aug 30, 2024

Suggested fix for:

Recording.2024-08-30.101635.mp4

This PR introduced handy-scroll, a dependency-free sibling of floating-scroll.

WIP is how to (correctly) install the required JS dependency and remove the responsive extension that is no longer required.

@chrisvanrun
Copy link
Contributor Author

Following a sync discussion with James the following was concluded:

  • amass is possibly doing odd things, it running on the main/amass.lock should not result in any changes
  • The testing of the impact of these changes in the PR are too big for a cooldown week project

Rather, changing the way modals operate is the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant