Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize section rendering for workstation configuration pages #3359

Conversation

pkcakeout
Copy link
Contributor

Problem

There currently is huge hand-written template html file to add nice sections to the workstation configuration detail page:

image

However, when clicking "edit", the edit form does not have these sections, even though they are quite handy for such a massive page with many many different configuration options. Also the order of entries differs from the details page. A very confusing situation.

Solution

  • I moved the grouping into the python code, specifically a module called visual_field_ordering. This defines a list of names that should be rendered on the different pages (edit form vs details) as well information about the sections
  • The hand-written details template was replaced with a generic one that includes special handling for the different field types using some added template-filters and tags

@pkcakeout pkcakeout mentioned this pull request May 30, 2024
@pkcakeout pkcakeout marked this pull request as ready for review May 30, 2024 11:27
@pkcakeout pkcakeout requested a review from jmsmkn as a code owner May 30, 2024 11:27
@jmsmkn
Copy link
Member

jmsmkn commented Jun 5, 2024

Replaced by #3366

@jmsmkn jmsmkn closed this Jun 5, 2024
@pkcakeout pkcakeout deleted the better-generalized-sections-for-workstation-configurations branch June 5, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants