Scoring: exclude_from_ranking #3352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmsmkn
reviewed
May 24, 2024
|
I would have thought that the template and view would need updating too as the rank will not be present for excluded fields, right? |
I might have completely missed the fact that the leaderboard templating changed if the scoring method changed! I'll look into this after the weekend. |
|
Refactor the test(s) and have updated the leaderboard template to not decorate the excluded metrics: |
jmsmkn
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the tiny pitch:
This PR adds an optional (default: false)
exclude_from_rankingfield in the extra results columns JSON definition. Setting it totrueallows additional metrics to be shown on Challenge leaderboards while being ignored while calculating the rank.The related test is a construction copy of
test_calculate_rankssince I did not find it wise to extend that test with yet another factor. It would have pushed the 12 (2x3x2) to 24 which is over the top imho.