Fix unique title mixins name and test

app/grandchallenge/archives/forms.py

@@ -24,10 +24,10 @@
 )
 from grandchallenge.components.models import ComponentInterface, InterfaceKind
 from grandchallenge.core.forms import (
-    CreateUniqueTitleFormMixin,
     PermissionRequestUpdateForm,
     SaveFormInitMixin,
-    UpdateUniqueTitleFormMixin,
+    UniqueTitleCreateFormMixin,
+    UniqueTitleUpdateFormMixin,
     WorkstationUserFilterMixin,
 )
 from grandchallenge.core.guardian import get_objects_for_user
@@ -252,7 +252,7 @@ def unique_title_query(self, *args, **kwargs):
 
 class ArchiveItemCreateForm(
     ArchiveItemFormMixin,
-    CreateUniqueTitleFormMixin,
+    UniqueTitleCreateFormMixin,
     CIVSetCreateFormMixin,
     MultipleCIVForm,
 ):
@@ -261,7 +261,7 @@ class ArchiveItemCreateForm(
 
 class ArchiveItemUpdateForm(
     ArchiveItemFormMixin,
-    UpdateUniqueTitleFormMixin,
+    UniqueTitleUpdateFormMixin,
     CIVSetUpdateFormMixin,
     MultipleCIVForm,
 ):

app/grandchallenge/core/forms.py

@@ -54,7 +54,7 @@ class Meta:
         fields = ("status", "rejection_text")
 
 
-class CreateUniqueTitleFormMixin:
+class UniqueTitleCreateFormMixin:
     """
     Form mixing creating an item with a unique title.
 
@@ -84,7 +84,7 @@ def unique_title_query(self, title):
         return self.model.objects.filter(title=title)
 
 
-class UpdateUniqueTitleFormMixin(CreateUniqueTitleFormMixin):
+class UniqueTitleUpdateFormMixin(UniqueTitleCreateFormMixin):
     def unique_title_query(self, *args, **kwargs):
         return (
             super()

app/grandchallenge/reader_studies/forms.py

@@ -40,10 +40,10 @@
 )
 from grandchallenge.components.models import ComponentInterface
 from grandchallenge.core.forms import (
-    CreateUniqueTitleFormMixin,
     PermissionRequestUpdateForm,
     SaveFormInitMixin,
-    UpdateUniqueTitleFormMixin,
+    UniqueTitleCreateFormMixin,
+    UniqueTitleUpdateFormMixin,
     WorkstationUserFilterMixin,
 )
 from grandchallenge.core.layout import Formset
@@ -693,7 +693,7 @@ def unique_title_query(self, *args, **kwargs):
 
 class DisplaySetCreateForm(
     DisplaySetFormMixin,
-    CreateUniqueTitleFormMixin,
+    UniqueTitleCreateFormMixin,
     CIVSetCreateFormMixin,
     MultipleCIVForm,
 ):
@@ -702,7 +702,7 @@ class DisplaySetCreateForm(
 
 class DisplaySetUpdateForm(
     DisplaySetFormMixin,
-    UpdateUniqueTitleFormMixin,
+    UniqueTitleUpdateFormMixin,
     CIVSetUpdateFormMixin,
     MultipleCIVForm,
 ):

app/tests/core_tests/test_forms.py

@@ -2,8 +2,8 @@
 from django.forms import Form
 
 from grandchallenge.core.forms import (
-    CreateUniqueTitleFormMixin,
-    UpdateUniqueTitleFormMixin,
+    UniqueTitleCreateFormMixin,
+    UniqueTitleUpdateFormMixin,
 )
 from grandchallenge.reader_studies.models import DisplaySet
 from tests.reader_studies_tests.factories import DisplaySetFactory
@@ -12,7 +12,7 @@
 @pytest.mark.django_db
 @pytest.mark.parametrize(
     "form_class",
-    (CreateUniqueTitleFormMixin, UpdateUniqueTitleFormMixin),
+    (UniqueTitleCreateFormMixin, UniqueTitleUpdateFormMixin),
 )
 @pytest.mark.parametrize(
     "existing_title,new_title,expected_validity",
@@ -29,8 +29,8 @@ def test_unique_title_mixin(
 ):
 
     class TestForm(form_class, Form):
-        class Meta:
-            model = DisplaySet  # For ease, use an existing model with a title
+
+        model = DisplaySet  # For ease, use an existing model with a title
 
         def __init__(self, *args, instance, **kwargs):
             self.instance = instance
@@ -42,7 +42,7 @@ def __init__(self, *args, instance, **kwargs):
 
     # Adapt for updating
     instance = None
-    if form_class == UpdateUniqueTitleFormMixin:
+    if form_class == UniqueTitleUpdateFormMixin:
         instance = DisplaySetFactory()
 
     form = TestForm(