use server.start and server.stop to end sunspot_solr after finishing … #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @manlycode, |
manlycode
reviewed
Feb 12, 2018
lib/sunspot_test.rb
Outdated
| STDERR.reopen("/dev/null") | ||
| STDOUT.reopen("/dev/null") | ||
| server.run | ||
| server.start |
There was a problem hiding this comment.
@rocket-turtle Why start rather than run?
There was a problem hiding this comment.
Yes sunspot manages all the pid file handling and the forking when we use start and stop.
The only downside I see is that you can only start one test sunspot server because they use all the same pid file. But I don't know if it is possible to run multiple instances at all.
We could also do something like this:
justinko/sunspot-rails-tester@680a5d9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the tests #30
#30