Force th of tr.month to be centered. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvelarde
requested changes
Jun 12, 2018
This is being done because of bootstrap. An example is collective.upload, that it's using bootstrap: in https://github.com/collective/collective.upload/blob/45278693169d568da9205863ec6e03cd977884f5/webpack/app/upload.less#L6 -> https://github.com/distros/bootstrap-less/blob/f07af08fe8bdafb334df3d86e5e6790b842d4cbf/bootstrap/tables.less#L15 you can see that th { text-align: left; } Is defined and will have impact in all layouts like here in collective.portlet.calendar if you have collective.upload installed. This was motivated (in portuguese) in plonegovbr/brasil.gov.agenda#82 (comment).
idgserpro
force-pushed
the
idgserpro-patch-1-bootstrap-risk
branch
from
99ec207 to
bad3872
Compare
Done.
Who would you suggest? @keul are you still active in this project? |
hvelarde
approved these changes
Jun 12, 2018
|
never mind, I think this is our own dog's food. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is being done because of bootstrap.
An example is collective.upload, that it's using bootstrap: in https://github.com/collective/collective.upload/blob/45278693169d568da9205863ec6e03cd977884f5/webpack/app/upload.less#L6 -> https://github.com/distros/bootstrap-less/blob/f07af08fe8bdafb334df3d86e5e6790b842d4cbf/bootstrap/tables.less#L15 you can see that
Is defined and will have impact in all layouts like here in collective.portlet.calendar if you have collective.upload installed.
This was motivated (in portuguese) in plonegovbr/brasil.gov.agenda#82 (comment).