DRYD-1374: Add objectCountGroup fields for collectionobject #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejritter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Why are we doing this? (with JIRA link)
This is a combination of 2 jiras:
This replaces the use of numberOfObjects with the new object count fields.
How should this be tested? Do these changes have associated tests?
Dependencies for merging? Releasing to production?
This requires the application PR for the
objectcounttypesvocabulary in order to populate theobjectCountTypefield.Has the application documentation been updated for these changes?
No
Did someone actually run this code to verify it works?
@mikejritter tested locally