Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRYD-1397: Add controlled object and material and fix ordering #16

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

mikejritter
Copy link
Contributor

What does this do?
This updates the forms which were missing the controlled fields from 7.2. It also updates ordering of the fields so that the controlled field is display first in the row.

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1397

This is something I discovered while adding public browser data through the template and realized I never updated the other forms to include these fields.

How should this be tested? Do these changes have associated tests?

  • Run the devserver
  • Create a collectionobject using...
    • photo template
    • public browser template
  • See that the controlled object name and controlled material fields exist and display first

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested against core, not against this profile

Copy link
Collaborator

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit 588859d into collectionspace:master Mar 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants