Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Layouts For Multiline Notes #13

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Update the annotation groups to allow for multiline notes
  • Update the loan groups to allow for multiline notes

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1284
Jira: https://collectionspace.atlassian.net/browse/DRYD-1285

This allows the annotationNote to be more useful in practice as users will be able to add useful information to the field.

How should this be tested? Do these changes have associated tests?

  • Run the devserver
  • Go to create a new procedure (acquisition, loanin, loanout, collectionobject) with the new layout see the annotation group with multiline input for the note
  • Create the new procedure with the annotation group fields filled out and verify it saves/reloads

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested against a local instance

Copy link
Collaborator

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit d21b6d1 into collectionspace:master Jan 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants