Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide associated authorities for person and place #50

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Hides the associated authorities block from the default form for person and place authorities

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1286

The associated authorities block was determined to only be needed for profiles with the chronology authority and is being hidden in others. These changes bring the default forms from cspace-ui and remove the associated authority block.

How should this be tested? Do these changes have associated tests?

  • Run the devserver
  • Create a person authority and see that the associated authorities block doesn't display
  • Create a place authority add see that the associated authorities block doesn't display

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested locally

Copy link

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit c6dd5fd into collectionspace:master Feb 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants