Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRYD-1357: Add Other Number/Other Number Type #48

Merged
merged 4 commits into from
Jan 17, 2024

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Adds Other Number Value and Type to the CollectionPbject form
  • Updates cspace-ui version for sso changes

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1357

The botgarden profile overrides the default form and these fields were missing.

How should this be tested? Do these changes have associated tests?

  • Start the dev server in the botgarden profile
  • Create a new CollectionObject with other number fields filled out
  • Verify the other number fields save

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested against a local install

@mikejritter
Copy link
Contributor Author

@ray-lee I just saw that on dev botgarden is using the new login page, so we have the option to rollback 66dc0f2.

Copy link

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit dab88bc into collectionspace:master Jan 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants