Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anthro osteology KS changes #62

Merged
merged 1 commit into from
Sep 11, 2020
Merged

anthro osteology KS changes #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/collectionspace/mapper/data_mapper_anthro_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
@osteologymapper = get_json_record_mapper(path: 'spec/fixtures/files/mappers/release_6_1/anthro/anthro_4_1_0-osteology.json')
@handler = DataHandler.new(record_mapper: @osteologymapper, cache: @cache, client: @client, config: @config)
end
context 'record 2' do
context 'record 1' do
before(:all) do
@datahash = get_datahash(path: 'spec/fixtures/files/datahashes/anthro/osteology1.json')
@prepper = DataPrepper.new(@datahash, @handler)
Expand Down
14 changes: 7 additions & 7 deletions spec/fixtures/files/datahashes/anthro/osteology1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@
"cranialDeformationCategory": "other (describe);tabular;circumferential",
"cranialDeformationNote": "of cranial deformation present",
"trepanationPresent": "false",
"trepanationLocation": "bone and side^^^^Gang Gang",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no repeating field subgroup inside this repeating field group, so use ; delimiter

"trepanationDimensionMax": "50^^^^90",
"trepanationDimensionMin": "^^60^^100",
"trepanationTechnique": "grooving^^^^grooving",
"trepanationHealing": "possible healing^^healing^^definite evidence for healing",
"trepanationCertainty": "possible trepanation^^clear evidence of trepanation^^",
"trepanationNote": "crazzy^^why why^^window",
"trepanationLocation": "bone and side;;Gang Gang",
"trepanationDimensionMax": "50;;90",
"trepanationDimensionMin": ";60;100",
"trepanationTechnique": "grooving;;grooving",
"trepanationHealing": "possible healing;no healing;definite evidence for healing",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no healing instead of healing

"trepanationCertainty": "possible trepanation;clear evidence of trepanation",
"trepanationNote": "crazzy;why why;window",
"trepanationGeneralNote": "earth long"
}
2 changes: 1 addition & 1 deletion spec/fixtures/files/mappers/release_6_1/anthro/anthro_4_1_0-osteology.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"profile_basename": "anthro",
"ns_uri": {
"osteology_common": "http://collectionspace.org/services/osteology",
"osteology_anthropology": null
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing the major initial error. I manually fixed the RecordMapper for osteology in the mapper fixtures. I made an issue here to fix the creation of the RecordMapper. I made Issue #63 to handle this failure more gracefully.

"osteology_anthropology": "http://collectionspace.org/services/osteology/domain/anthropology"
},
"identifier_field": "InventoryID"
},
Expand Down
3 changes: 1 addition & 2 deletions spec/fixtures/files/xml/anthro/osteology1.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@
<cranialDeformationCategory>urn:cspace:anthro.collectionspace.org:vocabularies:name(cranialdeformationcategory):item:name(tabular)'tabular'</cranialDeformationCategory>
<cranialDeformationCategory>urn:cspace:anthro.collectionspace.org:vocabularies:name(cranialdeformationcategory):item:name(circumferential)'circumferential'</cranialDeformationCategory>
</cranialDeformationCategories>
<Notes_NHTaphonomicAlterations>taphonomic alteration
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed new line since multiline field mapping worked ok in another test

</Notes_NHTaphonomicAlterations>
<Notes_NHTaphonomicAlterations>taphonomic alteration</Notes_NHTaphonomicAlterations>
<Notes_CulturalModifications>modification</Notes_CulturalModifications>
<Notes_CuratorialSuffixing>suffixing note</Notes_CuratorialSuffixing>
<Notes_PostcranialPathology>bony pathology</Notes_PostcranialPathology>
Expand Down