Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing test data, fix add_rownames deprecation #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

roryk
Copy link

@roryk roryk commented Mar 6, 2017

Hi everyone,

The tests don't pass, but the same tests don't pass in master. This pull request does two things:

  1. Includes the test data necessary for the tests to pass from https://github.com/cole-trapnell-lab/HSMMSingleCell
  2. fixes the add_rownames deprecation warning by swapping the calls to be tibble::column_to_rownames instead.

@ctrapnell
Copy link
Contributor

Thanks for this, @roryk. I realized I forgot to merge this before we passed the BioC 3.5 checkin deadline, and we're still fixing a few last minute things for the release. They ask that we not do anything other than fix docs and showstopper bugs in this release, but I will merge this as soon as the release is out. So it will be fixed in the next cycle. Sorry to be so slow, and thanks again for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants