Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @coldfire84,
I'd like to share my small feature "Add support for MQTTS certificates" with you. Background, why I implemented this: I'm hosting your great Alexa Home Skill on my own server within kubernetes. As I don't wanna transfer my mqtt message via unencrypted mqtt, I decided to setup the MQTT Server with a TLS config :) Therefore the new properties are needed. Also because of k8s, I needed an opportunity to use an different port than 1883 or 8883. Of course I could use my LoadBalancer Config to bind to 1883, but out of simplicity I'm gonna use a NodePort :D
TL;DR
I hope it's ok for you, that I coded this on my own ;) It was an interesting journey on how k8s, mqtt and alexa smart home skill works 👍
Greets,
Benjamin