Revert to a commit that works for race conditions handling #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Creating this PR to document why we reverted to this commit.
The addition from this commit broke race conditions handling.
Through a simple Rails app setup, it shows that introducing
ActiveRecordPoolControlcaused 2 instances ofLoadInterlockAwareMonitorto be created, and cannot effectively synchronise multiple threads accessing the same DB rows.To unblock our ruby3 upgrade, we will revert back to the commit that has worked before the introducing of the
ActiveRecordPoolControlclass.Commits cherry-picked from upstream