Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move internal utils to packages/core #1650

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

dschlabach
Copy link
Contributor

@dschlabach dschlabach commented Nov 21, 2024

What changed? Why?
This is our first refactor for supporting RN. Internal utils feel like the best place to start since it's almost all pure logic

We'll make these changes incrementally, but eventually expect our src dir to look like:

src/
├── packages/
│   ├── core/          # Pure TS/JS logic
│   ├── react/         # React components
│   └── react-native/  # RN components

Notes to reviewers

How has it been tested?

@dschlabach dschlabach changed the title chore: move internal utils to packages/core refactor: move internal utils to packages/core Nov 21, 2024
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 7:20pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 7:20pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 7:20pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant