feat: upgrade viem to support heterogeneous calls #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
abcrane123
changed the title
abcrane123
changed the title
alessey
reviewed
Oct 28, 2024
package.json
Outdated
| @@ -70,7 +70,7 @@ | |||
| "graphql-request": "^6.1.0", | |||
| "jsdom": "^24.1.0", | |||
| "packemon": "3.3.1", | |||
| "permissionless": "^0.1.29", | |||
| "permissionless": "^0.2.10", | |||
There was a problem hiding this comment.
are we still using this dependency after these changes (and under dependencies)?
abcrane123
force-pushed
the
alissa.crane/viem-upgrade
branch
from
f296883
to
38c7640
Compare
abcrane123
force-pushed
the
alissa.crane/viem-upgrade
branch
from
f44d315
to
f5bc044
Compare
0xAlec
reviewed
Nov 20, 2024
| @@ -93,75 +84,45 @@ export function TransactionProvider({ | |||
|
|
|||
| const { switchChainAsync } = useSwitchChain(); | |||
|
|
|||
| // Validate `calls` and `contracts` props | |||
| if (!contracts && !calls) { | |||
There was a problem hiding this comment.
nit: this is the same conditional
0xAlec
reviewed
Nov 20, 2024
Comment on lines
-139
to
-160
| // For batched, use statusSendCalls or statusWriteContracts | ||
| // For single, use statusSendCall or statusWriteContract | ||
| // For batched, use statusSendCalls | ||
| // For single, use statusSendCall | ||
| const transactionStatus = useMemo(() => { | ||
| const transactionStatuses = walletCapabilities[Capabilities.AtomicBatch] | ||
| ?.supported | ||
| ? { | ||
| [TRANSACTION_TYPE_CALLS]: statusSendCalls, | ||
| [TRANSACTION_TYPE_CONTRACTS]: statusWriteContracts, | ||
| } | ||
| : { | ||
| [TRANSACTION_TYPE_CALLS]: statusSendCall, | ||
| [TRANSACTION_TYPE_CONTRACTS]: statusWriteContract, | ||
| }; | ||
| return transactionStatuses[transactionType]; | ||
| }, [ | ||
| statusSendCalls, | ||
| statusWriteContracts, | ||
| statusSendCall, | ||
| statusWriteContract, | ||
| transactionType, | ||
| walletCapabilities[Capabilities.AtomicBatch], | ||
| ]); |
0xAlec
reviewed
Nov 20, 2024
src/transaction/types.ts
Outdated
Comment on lines
115
to
118
| transactions: | ||
| | Call[] | ||
| | ContractFunctionParameters[] | ||
| | (Call | ContractFunctionParameters)[]; |
There was a problem hiding this comment.
Suggested change
| transactions: | |
| | Call[] | |
| | ContractFunctionParameters[] | |
| | (Call | ContractFunctionParameters)[]; | |
| transactions: (Call | ContractFunctionParameters)[]; |
0xAlec
approved these changes
Nov 20, 2024
alessey
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
How has it been tested?