fix(lerna): aggressive patch bump #1163
Conversation
SudilHasithaCognite
added
the
do-not-merge
There was a problem hiding this comment.
Im not too familiar with this setup, but from what I see, it seems like this changes a bit of the release logic. We should then also update the
CONTRIBUTING Readme
so it mirrors these changes. Both regarding to the logic we should have when we remove
--conventional-commits
The logic around bump-verion etc.
I'm not too opinionated on what the best release strategy is as long as it is well documented
SudilHasithaCognite
removed
the
do-not-merge
Updated the contributing guidelines. |
There was a problem hiding this comment.
I think we should add some details on how we want to work with release branches. In other repos I have worked with, all fixes are merged into master, and then fixes are cherry picked from master to release branches. We should have some documentation on how we want to do this?
CONTRIBUTING.md
Outdated
| @@ -166,72 +172,4 @@ git push && git push --tags | |||
| ``` | |||
|
|
|||
| This will make a commit with the updated `package.json`, create a new git tag, and publish to npm. | |||
| Make sure you are logged in to npm, talk to a maintainer. | |||
|
|
|||
| ## Code overview | |||
There was a problem hiding this comment.
I wonder why the "Code overview" section is removed in the PR?
| if [[ "${GITHUB_REF}" == "refs/heads/master" ]]; then | ||
| EVENT_PATH_CONTENT=$(cat ${GITHUB_EVENT_PATH} | jq -r '.') | ||
| HEAD_COMMIT_MSG=$(echo $EVENT_PATH_CONTENT | jq -r '.head_commit.message') | ||
| MERGE_COMMIT_MSG=$(echo $EVENT_PATH_CONTENT | jq -r '.commits[-1].message') | ||
|
|
||
| if [[ "$HEAD_COMMIT_MSG" == *"Merge"* && "$HEAD_COMMIT_MSG" == *"release-"* && "$HEAD_COMMIT_MSG" == *"[release]"* ]] || | ||
| [[ "$MERGE_COMMIT_MSG" == *"Merge"* && "$MERGE_COMMIT_MSG" == *"release-"* && "$MERGE_COMMIT_MSG" == *"[release]"* ]]; then |
There was a problem hiding this comment.
These checks are a bit hard to read. What's the intention?
scripts/remove-rc-tags.js
Outdated
Addressing Lerna aggressive versioning
References
Modifications made