Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CDM Types #399

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Fix CDM Types #399

merged 1 commit into from
Sep 6, 2024

Conversation

ozangoktan
Copy link
Contributor

@ozangoktan ozangoktan commented Sep 6, 2024

Improved and fixed issues with types used for CDM TimeSeries

@ozangoktan ozangoktan changed the title CDM fixes Fix CDM Types Sep 6, 2024
@ozangoktan ozangoktan requested a review from a team September 6, 2024 15:04
@ozangoktan ozangoktan marked this pull request as ready for review September 6, 2024 15:04
@ozangoktan ozangoktan requested a review from a team as a code owner September 6, 2024 15:04
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 7.81250% with 59 lines in your changes missing coverage. Please review.

Project coverage is 61%. Comparing base (1bbdc1b) to head (f67e801).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
CogniteSdk.Types/Common/Converters.cs 0% 43 Missing ⚠️
...ogniteSdk.Types/Beta/DataModels/Core/Timeseries.cs 22% 14 Missing and 1 partial ⚠️
CogniteSdk.Types/Alpha/Common/Identity.cs 0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##           master   #399   +/-   ##
=====================================
- Coverage      61%    61%   -0%     
=====================================
  Files         355    355           
  Lines        6901   6959   +58     
  Branches      461    472   +11     
=====================================
+ Hits         4163   4179   +16     
- Misses       2487   2529   +42     
  Partials      251    251           
Files with missing lines Coverage Δ
Oryx.Cognite/src/Common.fs 88% <100%> (+1%) ⬆️
CogniteSdk.Types/Alpha/Common/Identity.cs 0% <0%> (ø)
...ogniteSdk.Types/Beta/DataModels/Core/Timeseries.cs 47% <22%> (-24%) ⬇️
CogniteSdk.Types/Common/Converters.cs 12% <0%> (-7%) ⬇️

... and 4 files with indirect coverage changes

@ozangoktan ozangoktan merged commit 2c5d877 into master Sep 6, 2024
5 checks passed
@ozangoktan ozangoktan deleted the cdm-fixes branch September 6, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants