Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQN Benchmarks #140

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

DQN Benchmarks #140

wants to merge 37 commits into from

Conversation

saikrishna-1996
Copy link
Contributor

@saikrishna-1996 saikrishna-1996 commented Mar 25, 2023

WIP

closes #76

@saikrishna-1996 saikrishna-1996 self-assigned this Mar 25, 2023
@saikrishna-1996 saikrishna-1996 marked this pull request as draft March 25, 2023 19:48
@saikrishna-1996 saikrishna-1996 marked this pull request as ready for review May 1, 2023 00:40
@cloderic cloderic requested a review from wduguay-air May 1, 2023 15:43
actors/dqn.py Show resolved Hide resolved
actors/dqn.py Show resolved Hide resolved
actors/dqn.py Show resolved Hide resolved
actors/dqn.py Outdated Show resolved Hide resolved
actors/dqn.py Show resolved Hide resolved
actors/dqn.py Outdated Show resolved Hide resolved
actors/dqn.py Outdated Show resolved Hide resolved
actors/dqn.py Outdated Show resolved Hide resolved
actors/dqn.py Outdated Show resolved Hide resolved
config/experiment/dqn/cartpole.yaml Outdated Show resolved Hide resolved
from cogment_verse.constants import PLAYER_ACTOR_CLASS

from cogment_verse import Model, TorchReplayBuffer # pylint: disable=abstract-class-instantiated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seed stuff should be in configs.

actors/dqn.py Outdated Show resolved Hide resolved
actors/dqn.py Outdated Show resolved Hide resolved
actors/dqn.py Outdated Show resolved Hide resolved
@cloderic cloderic changed the title Benchmarks DQN Benchmarks Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define and document good hyper parameters for SimpleDQN and SimpleA2C
2 participants