-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix notebook; re-add workflow #145
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
=======================================
Coverage 92.55% 92.55%
=======================================
Files 32 32
Lines 1948 1948
Branches 373 373
=======================================
Hits 1803 1803
Misses 74 74
Partials 71 71 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reformer_nn and reformer_nn_relu directories are generated when running notebooks. I've been excluding them from check-ins and I think that's the norm? But I see them here. (With Keras 3 they become single files so I would replace these in any case.)
Thanks for catching that. I went ahead and removed them from the PR. |
Legal Acknowledgement
By contributing to this software project, I agree my contributions are submitted under the BSD license.
I represent I am authorized to make the contributions and grant the license.
If my employer has rights to intellectual property that includes these contributions,
I represent that I have received permission to make contributions and grant the required license on behalf of that employer.