Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix notebook; re-add workflow #145

Merged
merged 10 commits into from
May 16, 2024

Conversation

jalving
Copy link
Collaborator

@jalving jalving commented May 8, 2024

Legal Acknowledgement
By contributing to this software project, I agree my contributions are submitted under the BSD license.
I represent I am authorized to make the contributions and grant the license.
If my employer has rights to intellectual property that includes these contributions,
I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.55%. Comparing base (72b9f65) to head (024f526).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   92.55%   92.55%           
=======================================
  Files          32       32           
  Lines        1948     1948           
  Branches      373      373           
=======================================
  Hits         1803     1803           
  Misses         74       74           
  Partials       71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jalving jalving requested a review from jezsadler May 16, 2024 17:42
Copy link
Collaborator

@jezsadler jezsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reformer_nn and reformer_nn_relu directories are generated when running notebooks. I've been excluding them from check-ins and I think that's the norm? But I see them here. (With Keras 3 they become single files so I would replace these in any case.)

@jalving
Copy link
Collaborator Author

jalving commented May 16, 2024

Thanks for catching that. I went ahead and removed them from the PR.

@jalving jalving merged commit 5e20b1b into cog-imperial:main May 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants