Disable federation by default #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Federation is now only enabled when a trust zone has a federation relationship with another trust zone. Fixes: #26
markgoddard
added a commit
that referenced
this pull request
Nov 18, 2024
After #27 merged we started seeing failures in the federation integration test: cofidectl workload discover Error: failed to stream exec: Internal error occurred: unable to upgrade connection: container not found ("spire-server") error: Recipe `integration-test` failed on line 20 with exit code 1 In #27 the Helm configuration was changed to only enable federation in SPIRE server when there is a federation relationship that has a bundle endpoint available. On the initial Helm install this would not be the case, so federation would be disabled. On the post-install configure Helm install, we would have bundle endpoints and so federation would be enabled and SPIRE server would be restarted. This caused any commands running immediately after cofidectl up that rely on SPIRE server being up (in this case `cofidectl workload discover`) to fail. This change addresses the issue by waiting for the SPIRE server pod and service to be ready after the post-install configuration step. Fixes: #36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Federation is now only enabled when a trust zone has a federation
relationship with another trust zone.
Fixes: #26