-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a workload status command #22
Conversation
8059397
to
a3612a6
Compare
d70a56e
to
ae18958
Compare
ae18958
to
e27f3f8
Compare
I've merged in FYI this PR depends on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
@nialdaly thanks for the approval, you've verified everything works for you? |
It worked well for me:
|
Hold off until debug container image hosting story is finalised |
e8d1c72
to
991f0f5
Compare
8f5eccb
to
185fb4d
Compare
Now using the GHCR image. CI is passing again ready for a last re-read before merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change has gone back to an earlier version prior to addressing review feedback. The commit that was approved was e27f3f8.
I think a bit of git magic will help here:
|
f911412
to
e8c4a7a
Compare
@markgoddard git surgery should be done! hope it worked out well... |
e8c4a7a
to
332d67c
Compare
I reworked it to be closer to the last approved patch and to use the statusspinner. |
This change adds a 'cofidectl workload status' command. The command accepts a trust zone, pod name and namespace, and deploys an ephemeral debug container to the pod. This container emits diagnostic information about the SVIDs provided to the workload. This requires us to set disableContainerSelectors=true in the SPIRE Helm configuration, to allow the debug container to obtain an ID. Fixes: #14 Co-Authored-By: Matt Bates <[email protected]> Co-Authored-By: Maartje Eyskens <[email protected]>
332d67c
to
8287ec5
Compare
cofidectl workload status foo --pod-name foo-pod --namespace bar --trust-zone foo
Initially, this command will take a workload name, with pod name, namespace and trust-zone as flags, and use Maartje's "attest-me" implementation via a debug container to return human-readable cert information with the CLI.
As a follow-up, I'd like to make it simpler to reference the workload (ideally a single argument) and for pod and cluster info be inferred, but that'll depend on how we handle 'workloads' and will need some additional thought.