Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webhook): display article reply's time instead of replies' time #384

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Jan 9, 2024

Because

  • reply time can be earlier than article time, leading to confusion
  • websites show article reply time in article detail

Thus we should display the time of article-reply in the place where we display reply times to reduce confusion

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7466516231

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 87.823%

Totals Coverage Status
Change from base Build 7465466044: 0.03%
Covered Lines: 1029
Relevant Lines: 1131

💛 - Coveralls

@MrOrz MrOrz changed the title feat(webhook): displau article reply's time instead of replies' time feat(webhook): display article reply's time instead of replies' time Jan 9, 2024
@MrOrz MrOrz requested a review from jtsaich January 9, 2024 20:32
@MrOrz MrOrz self-assigned this Jan 9, 2024
@MrOrz
Copy link
Member Author

MrOrz commented Jan 10, 2024

Tested on staging on wednesday, merging

@MrOrz MrOrz merged commit 1d089c5 into master Jan 10, 2024
9 checks passed
@MrOrz MrOrz deleted the use-ar-time branch January 10, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants