Check to see if response has Content-Length before setting it. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of codysoyland#12, I had to move PhasedRenderMiddleware to the bottom(ish) of my `MIDDLEWARE_CLASSES`. This fixed the issue with the `MessageMiddleware`, but caused new issues with other middleware I had that altered the length of the response. Ideally, these other middleware classes would check to see if `Content-Length` was set, and if so, re-adjust the content length header. Unfortunately, this doesn't seem to be the case, and it seems smart for us to check to see if the header's set before adding it in here, anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of #12, I had to move
PhasedRenderMiddlewareto the bottom(ish) of myMIDDLEWARE_CLASSES. This fixed the issue with theMessageMiddleware, but caused new issues with other middleware I had that altered the length of the response.Ideally, these other middleware classes would check to see if
Content-Lengthwas set, and if so, re-adjust the content length header. Unfortunately, this doesn't seem to be the case, and it seems smart for us to check to see if the header's set before adding it in here, anyway.