feat: add scoreboard for coubeh #117
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Peïo Thibault <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Peïo Thibault <[email protected]>
Co-authored-by: Yanzi-dev <[email protected]> Co-authored-by: Manuel <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Peïo Thibault <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
I can't test with multiples account discord, so i don't know if all my features works perfectly or not.. |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
potb
previously approved these changes
Nov 12, 2023
potb
previously approved these changes
Nov 12, 2023
potb
requested review from
neolectron and
luca-montaigut
and removed request for
neolectron
src/core/cache.ts
Outdated
| @@ -25,6 +25,7 @@ interface CacheEntries { | |||
| onDemandChannels: string[]; | |||
| quoiFeurChannels: string[]; | |||
| recurringMessages: { id: string; channelId: string; frequency: Frequency; message: string }[]; | |||
| score: { id: string; username: string; score: number }[]; | |||
There was a problem hiding this comment.
I think it's useless to store the username because it can change at any time. But you need to store the guild id.
Also, you can store score for coubeh and score for feur
PS: name the key scoreQuoiFeur or something more specific
There was a problem hiding this comment.
Hey ! Thank for review, working on it 👯♂️
auto-merge was automatically disabled
November 13, 2023 17:01
Head branch was pushed to by a user without write access
potb
force-pushed
the
master
branch
2 times, most recently
from
c69e2ce
to
a754471
Compare
|
@Alexandre-Chs do we keep that opened ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality add a scoreboard of all users who have been coubeh.
See the scoreboard : /quoi-feur scoreboard
The scoreboard only displays the top 3 users who have been coubeh.