Resolve Issue #809 #812
Closed
Resolve Issue #809 #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just read your comment about doing 92 Trap soon after doing it myself, hope you don't mind :) |
|
No worries, I was gonna do it later today so I haven't started yet, can you @ mention me in the pr so I can update #595 when you get it done? |
|
Oops, I created conflicts. My bad! |
|
no worries, given that the PR that created the conflict also fixes this issue, I'd say it's safe to just close this PR |
Sure thing, I will do that in the future. The 92 Trap PR is complete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#809 brought to my attention that I had mistakenly pushed the same code to two games (pushed 91_train to 91_train and 92_trap), this PR removes the rust implementation of 92_trap (which was really just 91_train), I'll probably contribute an actual implementation of 92_trap soon.
Sorry about this, but glad it's fixed now :)