Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add structured data for question pages #932

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MoshiKoi
Copy link
Member

@MoshiKoi MoshiKoi commented Jan 3, 2023

Working on #906

This should work, as shown here, but I'm not sure why the preview doesn't. If you have any insights, please let me know; I'm not familiar with SEO things.

@ullallulloo
Copy link

Google is very unpredictable about what previews it shows. I don't know why the preview doesn't show up in Google's tool, but I don't see how it could be anything wrong with the schema data.

@cellio
Copy link
Member

cellio commented Nov 20, 2023

This has been in draft state for a while. What additional work do we need to do?

@MoshiKoi
Copy link
Member Author

Honestly forgot I made this whoops

The main thing is that I have no way of actually knowing whether it works or not until it gets put on the server and I see if Google does the preview when I search. As mentioned above, Google's test page doesn't preview it correctly, so I'm not sure the generated schema is correct.

Maybe it could be put on the dev server to test...? I'm not sure if it's indexed.

@cellio
Copy link
Member

cellio commented Nov 24, 2023

If it doesn't work, will the change do any harm? (I gather not?) @ArtOfCode- , do you have an opinion on this?

@ullallulloo
Copy link

Note that I made a PR on @MoshiKoi 's fork fixing a couple of bugs, but besides that I would say it should be merged. Providing the data can only help.

@cellio cellio requested a review from a team November 26, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants