Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add set proxy configuration #8

Merged
merged 62 commits into from
Oct 19, 2021
Merged

Conversation

paule96
Copy link
Member

@paule96 paule96 commented Oct 14, 2021

closes #7

This brings many changes with it:

  • Linux and windows support in the build pipeline
  • Set-ProxyScript (works for linux and windows)

open things

[ ] docs missing

@paule96 paule96 added the enhancement New feature or request label Oct 14, 2021
@paule96 paule96 requested a review from kirkone October 14, 2021 21:35
@paule96
Copy link
Member Author

paule96 commented Oct 14, 2021

cc @DanielHabenicht

@DanielHabenicht
Copy link
Collaborator

Would be pretty fun to set up some End2End Tests for this Tool :D

@paule96
Copy link
Member Author

paule96 commented Oct 15, 2021

Would be pretty fun to set up some End2End Tests for this Tool :D

make an issue for that. And then we can discuss there an infrastructure for that. It will be really complex I think. Because you would need something like this:

  • a Machine A that would be the test machine
  • a Machine B that stands in the same network as Machine A and can directly accessed by it
  • a Machine C that is in a different network and can't be reached by Machine A
  • a Machine D that is in both networks and runs the proxy

Note: The machines can be containers or full vms. shouldn't matter
Note 2: Machine A should be Windows, Linux and MacOs at the same time

@DanielHabenicht
Copy link
Collaborator

I made an issue for it: #12

@paule96 paule96 merged commit c95edcc into main Oct 19, 2021
@paule96 paule96 deleted the paule96/add_set_proxy_configuration branch October 19, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a set proxy script
3 participants