[Feature] Select component for Codex UI #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Dropdown component implementation, but in component only one option is selectable. Also updated icons package version in package json's
neSpecc
reviewed
Nov 28, 2024
|
why file in |
Changed Component's name from Select to Dropdown; Converting options list into Popover component
e11sy
previously requested changes
Dec 3, 2024
Popover component's logic changed
There was some mess with component's name, because Dropdown and Select lots in common, so now this is Select component Also added ability to toggle select by clicking on selection button
DeadCreator
changed the title
DeadCreator
requested review from
e11sy
and removed request for
neSpecc and
e11sy
|
can't see the icon of the select |
e11sy
reviewed
Dec 12, 2024
|
Strange, locally everything is fine...Maybe the reason is that the icon was recently added to icons pack |
neSpecc
reviewed
Dec 12, 2024
Optimized and improved logic of Select Component; Refactored classes in ContextMenuItem Component Fixed not working onActive method by clicking on element's padding
neSpecc
reviewed
Dec 14, 2024
neSpecc
approved these changes
Dec 14, 2024
e11sy
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Dropdown component implementation (#273), but in component only one option is selectable. Also updated icons package version in package json's