feat(tests): noteList.test #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*added test added for /notes of one user *added insertUserSessions function *added json file for insertUserSessions function *added notes to notes.json (now 50) with one user_id *renamed notes-settings to camelcase notesSettings now
neSpecc
reviewed
Oct 22, 2023
| headers: { | ||
| authorization: `Bearer ${access_token}`, | ||
| }, | ||
| url: '/notes/&page=3', |
There was a problem hiding this comment.
Suggested change
| url: '/notes/&page=3', | |
| url: '/notes/?page=3', |
| expect(body).toHaveLength(portionSize); | ||
| }); | ||
|
|
||
| test('Returns noteList with no items if page*portionSize > numberOfNotes', async () => { |
There was a problem hiding this comment.
better to write with normal sentences
| expect(response?.statusCode).toBe(expextedStatus); | ||
| }); | ||
|
|
||
| test('Returns 400 when page > 0', async () => { |
There was a problem hiding this comment.
Suggested change
| test('Returns 400 when page > 0', async () => { | |
| test('Returns 400 when page is too large', async () => { |
- fixed comments logic - trying to fix directoru error
chore: move bis-logic from ui do domain, decouple domains
fixed sql syntax
fixed sql syntax
changed variable name
feat(editor-tools): default tools added to user tools, global "underscore" options in models
On pull/push: run build check, eslint check, tests. On push to main additionally deploy.
- trying to fix test problem with auth
- deleted error for tests throw - lint fixes
Divided enlist and build-push action to 2 separated actions
New data for tests were added to the test database
url for a fake request define using the find method
fix implicit arrange
Quickfix: added synchronize trigger on PR to actions
- noteList test logic fixed (authorization for specific user needed)
slaveeks
approved these changes
Nov 1, 2023
Fix multiple run of github action
Need to decide what to do with the note creator.
Removed 1 test case for 406
Tests for get note by id
- new Globally exposed method for creating accessToken using id (global.auth)
- added description of global.auth method into readme
- renamed variable from id to userId - typo fixed
feat(tests) : auth method added
- authtorization with global.auth instead of fake request function - data variables renamed to camelCase - solved conflicts in test data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/notesof one usernotesSettings now