Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed validation of upload file response type, fixed policy of getting file(added necessary preHandlers) #259

Merged
merged 5 commits into from
Jun 29, 2024
Merged

fix: fixed validation of upload file response type, fixed policy of getting file(added necessary preHandlers) #259

merged 5 commits into from
Jun 29, 2024

Conversation

slaveeks
Copy link
Member

  1. fixed validation of upload file response type, for now file key returns correctly
  2. fixed policy of getting file, it did not work

@slaveeks slaveeks requested review from neSpecc, GeekaN2 and e11sy June 29, 2024 16:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 29, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 86.06% (🎯 80%)
⬆️ +0.05%		 7558 / 8782
🟢 Statements 86.06% (🎯 80%)
⬆️ +0.05%		 7558 / 8782
🔴 Functions 79.47% (🎯 80%)
🟰 ±0%		 240 / 302
🟢 Branches 85.81% (🎯 80%)
🟰 ±0%		 375 / 437
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/presentation/http/http-api.ts 96.01% 90.32% 93.75% 96.01% 100-108, 119-120, 319-320, 343-344
src/presentation/http/router/upload.ts 81.52% 100% 100% 81.52% 112-138, 172-178
Generated in workflow #743

neSpecc
neSpecc reviewed Jun 29, 2024
View reviewed changes
Copy link
Member

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about tests?

@slaveeks slaveeks merged commit 8fcfee0 into main Jun 29, 2024
6 checks passed
@neSpecc neSpecc deleted the fix/upload-router branch June 29, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e11sy e11sy e11sy approved these changes

@kloV148 kloV148 kloV148 approved these changes

@neSpecc neSpecc neSpecc approved these changes

@GeekaN2 GeekaN2 Awaiting requested review from GeekaN2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slaveeks @neSpecc @kloV148 @e11sy