Chore(auth): store refresh token in cookie #240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
neSpecc
reviewed
Apr 4, 2024
| }) | ||
| .send({ | ||
| accessToken, | ||
| refreshToken, |
There was a problem hiding this comment.
you don't need to send rt via json then
src/domain/service/auth.ts
Outdated
| @@ -71,7 +71,7 @@ export default class AuthService { | |||
| * @param userId - user to sign refresh token for | |||
| * @returns {Promise<string>} refresh token | |||
src/presentation/http/router/auth.ts
Outdated
| @@ -23,6 +23,11 @@ interface AuthRouterOptions { | |||
| * Auth service instance | |||
| */ | |||
| authService: AuthService, | |||
|
|
|||
| /** | |||
| * Cookie domain for refresh and access tokens | |||
There was a problem hiding this comment.
Suggested change
| * Cookie domain for refresh and access tokens | |
| * Cookie domain for refresh token |
| refreshToken, | ||
| }); | ||
| return reply | ||
| .setCookie('refreshToken', refreshToken, { |
There was a problem hiding this comment.
I think this naming is not clear enough
There was a problem hiding this comment.
camel case is not a common practice for cookie names, as I know
There was a problem hiding this comment.
Maybe use snake case instead? refresh_token for example
kloV148
force-pushed
the
chore/http-cookie-refresh-token
branch
from
fcef5b5 to
49c2a8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, we store refresh token as http only cookie